Skip to content

Generate Builder methods on Beans #1162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2025
Merged

Generate Builder methods on Beans #1162

merged 1 commit into from
Jul 4, 2025
+1,415 −5

Conversation

@cmoine-swi
Copy link
Contributor

@cmoine-swi cmoine-swi commented May 27, 2025 •
edited
Loading

Implement #1160

Expose the option generateBuilders from jsonschema2pojo

@cmoine-swi cmoine-swi requested a review from a team as a code owner May 27, 2025 12:45
@hbelmiro hbelmiro linked an issue May 27, 2025 that may be closed by this pull request
Generate Builder methods on Beans #1160
Closed
@ricardozanini ricardozanini added the area:server This item is related to the server extension label May 27, 2025
gmunozfe
gmunozfe reviewed May 28, 2025
View reviewed changes
Copy link
Contributor

@gmunozfe gmunozfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution @cmoine-swi !
Great work!
Could you add also some integration tests for validating both values:
quarkus.openapi.generator.generate-builders=true/false

@cmoine-swi cmoine-swi force-pushed the Generate-builder-methods-on-beans branch from 6efe4a5 to 5fa7ce6 Compare June 13, 2025 07:48
@cmoine-swi
Copy link
Contributor Author

cmoine-swi commented Jun 13, 2025

@gmunozfe Thx, sorry for the delay. Please find the Integration Tests 😉

@ricardozanini ricardozanini requested a review from mcruzdev June 13, 2025 16:46
mcruzdev
mcruzdev requested changes Jun 19, 2025
View reviewed changes
Copy link
Member

@mcruzdev mcruzdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cmoine-swi, thanks a lot for this great feature and sorry for my delay.

I left some comments, could you take a look? Thanks again.

mcruzdev
mcruzdev reviewed Jun 20, 2025
View reviewed changes
mcruzdev
mcruzdev reviewed Jun 20, 2025
View reviewed changes
mcruzdev
mcruzdev reviewed Jun 20, 2025
View reviewed changes
@cmoine-swi cmoine-swi requested a review from mcruzdev June 23, 2025 07:11
@mcruzdev
Copy link
Member

mcruzdev commented Jun 26, 2025

Hi @cmoine-swi!
I think it is close, we need to format:

Imports are not sorted in ApicurioCodegenWrapper.java

Try to run:

mvn -f server net.revelc.code:impsort-maven-plugin:1.12.0:sort

mcruzdev
mcruzdev approved these changes Jul 4, 2025
View reviewed changes
Copy link
Member

@mcruzdev mcruzdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @cmoine-swi for your contribution, could you squash all commits in one :)

@mcruzdev mcruzdev requested a review from gmunozfe July 4, 2025 01:17
@cmoine-swi cmoine-swi force-pushed the Generate-builder-methods-on-beans branch from ad51850 to be7821b Compare July 4, 2025 06:54
@mcruzdev mcruzdev merged commit 111931d into quarkiverse:main Jul 4, 2025
11 checks passed
@github-actions github-actions bot mentioned this pull request Jul 4, 2025
Merged
@mcruzdev
Copy link
Member

mcruzdev commented Jul 13, 2025

@all-contributors please add @cmoine-swi for code

@allcontributors allcontributors bot mentioned this pull request Jul 13, 2025
Merged
@allcontributors
Copy link
Contributor

allcontributors bot commented Jul 13, 2025

@mcruzdev

I've put up a pull request to add @cmoine-swi! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcruzdev mcruzdev mcruzdev approved these changes

@gmunozfe gmunozfe Awaiting requested review from gmunozfe

Assignees

No one assigned

Labels

area:server This item is related to the server extension backport-main-lts

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Generate Builder methods on Beans

5 participants

@cmoine-swi @mcruzdev @gmunozfe @ricardozanini @hbelmiro